-
Notifications
You must be signed in to change notification settings - Fork 205
feat: Add support for MONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TF
#3505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ONGODB_ATLAS_PRIVATE_API_KEY ` to TF
MONGODB_ATLAS_PRIVATE_API_KEY
to TFMONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TF
MONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TFMONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TF
MONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TFMONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TF
APIx bot: a message has been sent to Docs Slack channel |
MONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TFMONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to TF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for new environment variables MONGODB_ATLAS_PUBLIC_API_KEY
and MONGODB_ATLAS_PRIVATE_API_KEY
to the Terraform provider, which are widely used across the MongoDB ecosystem and provide better compatibility with other MongoDB tools.
- Adds the new environment variables to both SDK2 and framework provider implementations
- Updates documentation to recommend the new environment variables over the existing ones
- Includes changelog entry documenting the new feature
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
internal/provider/provider_sdk2.go | Adds new environment variables to the SDK2 provider configuration |
internal/provider/provider.go | Adds new environment variables to the framework provider configuration |
docs/index.md | Updates documentation to recommend new environment variables and explains compatibility benefits |
.changelog/3505.txt | Adds changelog entry for the new environment variables |
LGTM, only concern I have is that the usages of MONGODB_ATLAS_PUBLIC_KEY across the repo should be changed as well for consistency and to avoid confusion. Could be in this PR or a follow up |
I don't have a strong opinion but I don't think is needed since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few suggestions.
Nice! |
…_peering * CLOUDP-320243-dev-2.0.0: fix: Changes `actions` attribute to TypeSet in `mongodbatlas_custom_db_role` to not be sensitive to order (#3508) chore: Updates CHANGELOG.md for #3513 fix: Sets org_id on import of `mongodbatlas_organization` resource (#3513) go 1.24.5 (#3514) chore: Updates CHANGELOG.md for #3484 feat: Add azure attributes in federated database instance resource (#3484) chore: Updates CHANGELOG.md for #3505 feat: Add support for `MONGODB_ATLAS_PUBLIC_API_KEY` and `MONGODB_ATLAS_PRIVATE_API_KEY` to TF (#3505)
Description
Ticket: CLOUDP-332049